{"id":454,"date":"2016-11-04T11:43:33","date_gmt":"2016-11-04T10:43:33","guid":{"rendered":"http:\/\/jonika.nu\/JonasBlogg\/?p=454"},"modified":"2016-11-04T11:43:33","modified_gmt":"2016-11-04T10:43:33","slug":"recycle-bin-wont-empty-when-using-episerver-relate","status":"publish","type":"post","link":"https:\/\/jonika.nu\/JonasBlogg\/archives\/454","title":{"rendered":"Recycle bin won’t empty when using EPiServer Relate"},"content":{"rendered":"

A few days ago i found i strange behaviour on our intranet site. The waste basket didn’t empty! The scheduled job ran just fine, but the log always contained the same message: 0 content items were deleted from recycle bin<\/strong><\/p>\n

Thats a new one! So where to look? The logs are, off course, a great place to start looking for errors. The first line that cought my attention was this one: ERROR EPiServer.Util.EmptyWastebasketJob: 17.3.1 Error when trying to delete content from recycle bin<\/strong><\/p>\n

At first, i thought it was some kind of permission issue. The site runs Windows authentication, and that has some side effects, but than i found another line in the log: EPiServer.Core.TypeMismatchException: Content with id ‘<xxxxx>’ is of type ‘Castle.Proxies.FormContainerBlockProxy’ which does not inherit required type ‘EPiServer.Core.PageData’<\/strong><\/p>\n

and than another similar line: EPiServer.Core.TypeMismatchException: Content with id ‘29990’ is of type ‘EPiServer.Core.ContentFolder’ which does not inherit required type ‘EPiServer.Core.PageData’<\/strong><\/p>\n

I couldn’t believe there’s still code in EPiServer that requires PageData!! And, off couse, there wasn’t. BUT! EPiServer Relate is another story. The CmsIntegrationModule <\/strong>had a few fingers in that cookie jar!<\/p>\n

To be specific, the method RemovePageEntity, which deletes corresponding page entities when a page is deleted:<\/p>\n

        \/\/\/ <summary>\r\n        \/\/\/ Deletes the correspoinding <see cref=\"CMSPageEntity\"\/> when a page is deleted\r\n        \/\/\/ <\/summary>\r\n        \/\/\/ <param name=\"e\">The <see cref=\"EPiServer.PageEventArgs\"\/> instance containing the event data.<\/param>\r\n        private static void RemovePageEntity(PageEventArgs e)\r\n        {\r\n            if (e == null || PageReference.IsNullOrEmpty(e.PageLink))\r\n            {\r\n                return;\r\n            }\r\n            \r\n            CMSPageEntity pagedataEntity = CMSPageEntityHandler.Instance.GetEntity(e.Page.PageGuid, e.Page.LanguageBranch, 0);\r\n\r\n            if (pagedataEntity == null)\r\n            {\r\n                return;\r\n            }\r\n\r\n            CMSPageEntityHandler.Instance.RemoveEntity(pagedataEntity);\r\n        }<\/pre>\n
It first, it looks like the code really do try to avoid null references by checking if PageEventArgs<\/strong> are null and than if PageEventArgs.PageLink<\/strong> is null, but: when you have a ContentFolder<\/strong> or FormContiner<\/strong> in the recycle bin, both of them are set. The problem is that PageEventArgs.Page is null.<\/p>\n
So, just throw in one more null check for e.Page, like this:<\/p>\n
        \/\/\/ <summary>\r\n        \/\/\/ Deletes the correspoinding <see cref=\"CMSPageEntity\"\/> when a page is deleted\r\n        \/\/\/ <\/summary>\r\n        \/\/\/ <param name=\"e\">The <see cref=\"EPiServer.PageEventArgs\"\/> instance containing the event data.<\/param>\r\n        private static void RemovePageEntity(PageEventArgs e)\r\n        {\r\n            if (e == null || e.Page == null<\/strong> || PageReference.IsNullOrEmpty(e.PageLink))\r\n            {\r\n                return;\r\n            }\r\n            \r\n            CMSPageEntity pagedataEntity = CMSPageEntityHandler.Instance.GetEntity(e.Page.PageGuid, e.Page.LanguageBranch, 0);\r\n\r\n            if (pagedataEntity == null)\r\n            {\r\n                return;\r\n            }\r\n\r\n            CMSPageEntityHandler.Instance.RemoveEntity(pagedataEntity);\r\n        }<\/pre>\n
And you also need to handle errors in GetClubId. I took the easy way and put a try around the code.<\/p>\n
        private static int GetClubId(PageReference pageReference)\r\n        {\r\n            try\r\n            {\r\n                if (PageReference.IsNullOrEmpty(pageReference))\r\n                {\r\n                    return -1;\r\n                }\r\n\r\n                \/\/ Get the page\r\n                PageData page = DataFactory.Instance.GetPage(pageReference);\r\n\r\n                \/\/ Check if it is an article page, if not return\r\n                if (page is ArticlePage && ((ArticlePage)page).ClubAssociation > 0)\r\n                {\r\n                    return ((ArticlePage)page).ClubAssociation;\r\n                }\r\n                return -1;\r\n            }\r\n            catch { }\r\n\r\n            return -1;\r\n        }<\/pre>\n
Now the recycle bin should empty just fine!<\/p>\nFollow jonlin76<\/a>\n